Messages in this thread | | | Date | Sat, 25 Jan 2014 23:29:29 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 3/4] power_supply: Introduce PSE compliant algorithm |
| |
Hi!
> +config POWER_SUPPLY_CHARGING_ALGO_PSE > + bool "PSE compliant charging algorithm" > + help > + Say Y here to select PSE compliant charging algorithm. As per PSE > + standard the battery characteristics and thereby the charging rates
It would be good to explain PSE here.
> +#define MAINT_EXIT_OFFSET 50 /* mv */
mV
> +/* PSE Modified Algo Structure */ > +/* Parameters defining the charging range */ > +struct psy_ps_temp_chg_table { > + /* upper temperature limit for each zone */ > + short int temp_up_lim; > + /* charge current and voltage */ > + short int full_chrg_vol; > + short int full_chrg_cur;
It would be good to add units here. And vowels.
> + /* type of battery */ > + u16 battery_type; > + u16 capacity; > + u16 voltage_max; > + /* charge termination current */ > + u16 chrg_term_ma; > + /* Low battery level voltage */ > + u16 low_batt_mv; > + /* upper and lower temperature limits on discharging */ > + u8 disch_tmp_ul; > + u8 disch_tmp_ll;
tmp sounds like temporary, not temperature. just use full words.
Add units. And u8 is probably not right type for temperature.
> + /* number of temperature monitoring ranges */ > + u16 temp_mon_ranges; > + struct psy_ps_temp_chg_table temp_mon_range[BATT_TEMP_NR_RNG]; > + /* Lowest temperature supported */ > + short int temp_low_lim;
Add units.
Also check multiline comment codingstyle. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |