Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH 4/4] power_supply: bq24261 charger driver | Date | Wed, 29 Jan 2014 16:26:45 +0900 |
| |
On Wednesday, January 29, 2014 10:24 PM, Jenny Tc wrote: > On Tue, Jan 28, 2014 at 07:14:45AM -0700, Pavel Machek wrote: > > > +#define BQ24261_ICHRG_MASK (0x1F << 3) > > > +#define BQ24261_ICHRG_100ma (0x01 << 3) > > > +#define BQ24261_ICHRG_200ma (0x01 << 4) > > > +#define BQ24261_ICHRG_400ma (0x01 << 5) > > > +#define BQ24261_ICHRG_800ma (0x01 << 6) > > > +#define BQ24261_ICHRG_1600ma (0x01 << 7) > > > > First, its mA, not ma. > > Camel Case allowed? Ignore Checkpatch.pl warning?
Yep, Camel Case is allowed by the commit d8b0771 "checkpatch: extend CamelCase types and ignore existing CamelCase uses in a patch".
Thus, the following cases are currently allowed.
#define BQ24261_ICHRG_1600ma (0x01 << 7) #define BQ24261_ICHRG_1600MA (0x01 << 7) #define BQ24261_ICHRG_1600mA (0x01 << 7) ....
Best regards, Jingoo Han
> > > +u16 bq24261_iterm[][2] = { > > > + {0, 0x00} > > > + , > > > + {50, BQ24261_ITERM_50ma} > > > + , > > > + {100, BQ24261_ITERM_100ma} > > > + , > > > + {150, BQ24261_ITERM_100ma | BQ24261_ITERM_50ma} > > > > ...this is very obscure way to do with table what can be done with > > > > (x/50) << 3, right ? > > Few register settings need table mapping, but some can have logic as your > comment say. Just wanted to keep same logic for all register settings. > Doesn't it make more readable? > > > > +u16 bq24261_cc[][2] = { > > > + > > > + {500, 0x00} > > > + , > > > + {600, BQ24261_ICHRG_100ma} > > > + , > > > + {700, BQ24261_ICHRG_200ma} > > > + , > > > + {800, BQ24261_ICHRG_100ma | BQ24261_ICHRG_200ma} > > > + , > > > + {900, BQ24261_ICHRG_400ma} > > > > I suspect you can get rid of this, too, if you expand macros. > Same as above comment. > > -Jenny
| |