| Date | Mon, 23 Sep 2013 15:32:12 +0530 | Subject | Re: [PATCH 05/21] cpuidle: make __cpuidle_driver_init() return void | From | Viresh Kumar <> |
| |
On 23 September 2013 15:28, Hongbo Zhang <hongbo.zhang@freescale.com> wrote: > On 09/22/2013 09:20 AM, Viresh Kumar wrote: >> >> __cpuidle_driver_init() doesn't return anything except zero and so doesn't >> really need a return type other than void. >> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> >> --- >> drivers/cpuidle/driver.c | 8 ++------ >> 1 file changed, 2 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/cpuidle/driver.c b/drivers/cpuidle/driver.c >> index 25455e8..8df66c8 100644 >> --- a/drivers/cpuidle/driver.c >> +++ b/drivers/cpuidle/driver.c >> @@ -152,7 +152,7 @@ static void cpuidle_setup_broadcast_timer(void *arg) >> * >> * Returns 0 on success, a negative error code otherwise. > > If you want to make it return void, you should also update the above > comment.
Thanks for the correction..
|