Messages in this thread | | | Date | Thu, 26 Sep 2013 10:25:00 +0200 | From | Daniel Lezcano <> | Subject | Re: [PATCH 08/21] cpuidle: use cpuidle_disabled() instead of "off" |
| |
On 09/26/2013 07:06 AM, Viresh Kumar wrote: > On 26 September 2013 03:22, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: >> On 09/22/2013 03:21 AM, Viresh Kumar wrote: >>> We have a routine for getting value of "off", better call that instead of using >>> "off" directly. >> >> We are in the fast path, I am not sure invoking a function here is >> better than using directly the static variable. > > I only did it for consistency as we have this routine specifically for reading > value of "off" and so we better don't use off directly.. > > Probably we can make it static inline and move it into > drivers/cpuidle/cpuidle.h?
If you move it to cpuidle.h, you will have to move the 'off' variable in the header hence increasing the scope of it.
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |