| From | Kamal Mostafa <> | Subject | [PATCH 02/93] Revert "zram: use zram->lock to protect zram_free_page() in swap free notify path" | Date | Fri, 20 Sep 2013 13:07:57 -0700 |
| |
3.8.13.10 -stable review patch. If anyone has any objections, please let me know.
------------------
From: Kamal Mostafa <kamal@canonical.com>
This reverts commit f56c0e44628257f97063089eb865d5eb2dfdd642, which was commit 57ab048532c0d975538cebd4456491b5c34248f4 upstream.
BugLink: https://bugs.launchpad.net/bugs/1215513
f56c0e4 was identified as provoking the lockup bug noted above.
Cc: Jiang Liu <jiang.liu@huawei.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Luis Henriques <luis.henriques@canonical.com> Signed-off-by: Kamal Mostafa <kamal@canonical.com> --- drivers/staging/zram/zram_drv.c | 2 -- drivers/staging/zram/zram_drv.h | 5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index 62f8276..dd915ce 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -622,9 +622,7 @@ static void zram_slot_free_notify(struct block_device *bdev, struct zram *zram; zram = bdev->bd_disk->private_data; - down_write(&zram->lock); zram_free_page(zram, index); - up_write(&zram->lock); zram_stat64_inc(zram, &zram->stats.notify_free); } diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h index 4265ab4..df2eec4 100644 --- a/drivers/staging/zram/zram_drv.h +++ b/drivers/staging/zram/zram_drv.h @@ -92,9 +92,8 @@ struct zram { void *compress_buffer; struct table *table; spinlock_t stat64_lock; /* protect 64-bit stats */ - struct rw_semaphore lock; /* protect compression buffers, table, - * 32bit stat counters against concurrent - * notifications, reads and writes */ + struct rw_semaphore lock; /* protect compression buffers and table + * against concurrent read and writes */ struct request_queue *queue; struct gendisk *disk; int init_done; -- 1.8.1.2
|