lkml.org 
[lkml]   [2013]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/93] drivers/misc/hpilo: Correct panic when an AUX iLO is detected
    Date
    3.8.13.10 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Mark Rusk <Mark.Rusk@hp.com>

    commit eefbc594abbb1b7e6e7eeadb65ae7c7538474210 upstream.

    Using an uninitialized variable 'devnum' after 'goto out;' was causing
    panic. Just go ahead and return, we need to ignore AUX iLO devs.

    Oops: 0002 [#1] SMP
    .
    .
    .
    RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]

    Signed-off-by: Mark Rusk <mark.rusk@hp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/misc/hpilo.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/misc/hpilo.c b/drivers/misc/hpilo.c
    index 621c7a3..b83e3ca 100644
    --- a/drivers/misc/hpilo.c
    +++ b/drivers/misc/hpilo.c
    @@ -759,7 +759,7 @@ static int ilo_probe(struct pci_dev *pdev,

    /* Ignore subsystem_device = 0x1979 (set by BIOS) */
    if (pdev->subsystem_device == 0x1979)
    - goto out;
    + return 0;

    if (max_ccb > MAX_CCB)
    max_ccb = MAX_CCB;
    @@ -899,7 +899,7 @@ static void __exit ilo_exit(void)
    class_destroy(ilo_class);
    }

    -MODULE_VERSION("1.4");
    +MODULE_VERSION("1.4.1");
    MODULE_ALIAS(ILO_NAME);
    MODULE_DESCRIPTION(ILO_NAME);
    MODULE_AUTHOR("David Altobelli <david.altobelli@hp.com>");
    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-09-20 23:21    [W:2.244 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site