Messages in this thread | | | From | David Howells <> | Subject | Please discard "checkpatch: warn when using extern with function prototypes in .h files" | Date | Mon, 02 Sep 2013 14:51:33 +0100 |
| |
I noticed that a patch got committed to checkpatch to complain about function prototypes prefixed by "extern".
Please discard/revert this patch:
commit 7cd0f806622836e386ef18ad1950a9a729803019 Author: Joe Perches <joe@perches.com> Date: Wed Aug 28 10:16:00 2013 +1000 checkpatch: warn when using extern with function prototypes in .h files
Using the extern keyword on function prototypes is superfluous visual noise so suggest removing it.
This is inaccurate. It's actually a useful visual cue - so if anything, please make checkpatch indicate that it be added to all future function prototypes.
David
| |