lkml.org 
[lkml]   [2013]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectPlease discard "checkpatch: warn when using extern with function prototypes in .h files"
Date

I noticed that a patch got committed to checkpatch to complain about function
prototypes prefixed by "extern".

Please discard/revert this patch:

commit 7cd0f806622836e386ef18ad1950a9a729803019
Author: Joe Perches <joe@perches.com>
Date: Wed Aug 28 10:16:00 2013 +1000
checkpatch: warn when using extern with function prototypes in .h files

Using the extern keyword on function prototypes is superfluous visual
noise so suggest removing it.

This is inaccurate. It's actually a useful visual cue - so if anything, please
make checkpatch indicate that it be added to all future function prototypes.

David


\
 
 \ /
  Last update: 2013-09-02 16:01    [W:1.824 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site