lkml.org 
[lkml]   [2013]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 4/4] skd: remove unneeded NULL check
We already dereferenced "skdev" a few lines earlier in the debug code so
my static checker complains. I audited the callers and "skdev" is never
NULL here so I have removed the check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 20ad843..827f927 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2909,7 +2909,7 @@ static void skd_do_inq_page_da(struct skd_device *skdev,

inq.page_code = DRIVER_INQ_EVPD_PAGE_CODE;

- if (skdev && skdev->pdev && skdev->pdev->bus) {
+ if (skdev->pdev && skdev->pdev->bus) {
skd_get_link_info(skdev->pdev,
&inq.pcie_link_speed, &inq.pcie_link_lanes);
inq.pcie_bus_number = cpu_to_be16(skdev->pdev->bus->number);

\
 
 \ /
  Last update: 2013-09-13 10:21    [W:0.020 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site