Messages in this thread | | | Date | Thu, 01 Aug 2013 15:09:08 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH 2/6] usb: phy: tegra: Fix wrong PHY parameters |
| |
On 07/31/2013 11:41 AM, Tuomas Tynkkynen wrote: > Some of the PHY parameters are not set according to the TRMs: > > - UTMIP_FS_PREABMLE_J should be set, not cleared > - UTMIP_XCVR_LSBIAS_SEL should be cleared, not set > - UTMIP_PD_CHRG should be set in host mode and cleared in device mode > - UTMIP_XCVR_SETUP is a two-part field; the upper bits were not set
> diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
> #define UTMIP_XCVR_SETUP(x) (((x) & 0xf) << 0) > +#define UTMIP_XCVR_SETUP_MSB(x) ((((x) & 0x7f) >> 4) << 22)
You may as well s/0x7f/0x70/ since the shift clears the 4 LSBs. I'm pretty sure I mentioned this in downstream review. Perhaps check my review comments to see if anything else was missed?
| |