Messages in this thread | | | Date | Thu, 25 Jul 2013 14:18:12 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 04/36] tile: srom: convert srom_class to use dev_groups |
| |
On Thu, Jul 25, 2013 at 05:11:57PM -0400, Chris Metcalf wrote: > On 7/24/2013 6:13 PM, Greg Kroah-Hartman wrote: > > The dev_attrs field of struct class is going away soon, dev_groups > > should be used instead. This converts the tile srom_class code to use > > the correct field. > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > drivers/char/tile-srom.c | 28 ++++++++++++++++------------ > > 1 file changed, 16 insertions(+), 12 deletions(-) > > I just got a failed build email from the kisskb build server: > > drivers/char/tile-srom.c:308:2: error: initializer element is not computable at load time > drivers/char/tile-srom.c:308:2: error: (near initialization for 'srom_dev_attrs[0].mode') > > plus a bunch of warnings:
Yes, I just fixed that and pushed out my changes, I forgot a '*', sorry about that.
greg k-h
| |