Messages in this thread | | | Date | Thu, 25 Jul 2013 17:11:57 -0400 | From | Chris Metcalf <> | Subject | Re: [PATCH 04/36] tile: srom: convert srom_class to use dev_groups |
| |
On 7/24/2013 6:13 PM, Greg Kroah-Hartman wrote: > The dev_attrs field of struct class is going away soon, dev_groups > should be used instead. This converts the tile srom_class code to use > the correct field. > > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/char/tile-srom.c | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-)
I just got a failed build email from the kisskb build server:
drivers/char/tile-srom.c:308:2: error: initializer element is not computable at load time drivers/char/tile-srom.c:308:2: error: (near initialization for 'srom_dev_attrs[0].mode')
plus a bunch of warnings:
drivers/char/tile-srom.c:307:2: warning: missing braces around initializer [-Wmissing-braces] drivers/char/tile-srom.c:307:2: warning: (near initialization for 'srom_dev_attrs[0]') [-Wmissing-braces] drivers/char/tile-srom.c:307:2: warning: initialization from incompatible pointer type [enabled by default] drivers/char/tile-srom.c:307:2: warning: (near initialization for 'srom_dev_attrs[0].name') [enabled by default] drivers/char/tile-srom.c:308:2: warning: initialization makes integer from pointer without a cast [enabled by default] drivers/char/tile-srom.c:308:2: warning: (near initialization for 'srom_dev_attrs[0].mode') [enabled by default] drivers/char/tile-srom.c:309:2: warning: initialization from incompatible pointer type [enabled by default] drivers/char/tile-srom.c:309:2: warning: (near initialization for 'srom_dev_attrs[1].name') [enabled by default] drivers/char/tile-srom.c:310:2: warning: initialization makes integer from pointer without a cast [enabled by default] drivers/char/tile-srom.c:310:2: warning: (near initialization for 'srom_dev_attrs[1].mode') [enabled by default] drivers/char/tile-srom.c:312:1: warning: initialization from incompatible pointer type [enabled by default] drivers/char/tile-srom.c:312:1: warning: (near initialization for 'srom_dev_group.attrs') [enabled by default] -- Chris Metcalf, Tilera Corp. http://www.tilera.com
| |