Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Fix networking kernel-doc block comment defect | From | Joe Perches <> | Date | Wed, 24 Jul 2013 20:31:52 -0700 |
| |
checkpatch can generate a false positive when inserting a new kernel-doc block and function above an existing kernel-doc block.
Fix it by checking that the context line is also a newly inserted line.
Reported-by: Darren Hart <dvhart@linux.intel.com> Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 23126d4..c18e1be 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2074,6 +2074,7 @@ sub process { if ($realfile =~ m@^(drivers/net/|net/)@ && $prevrawline =~ /^\+[ \t]*\/\*/ && #starting /* $prevrawline !~ /\*\/[ \t]*$/ && #no trailing */ + $rawline =~ /^\+/ && #line is new $rawline !~ /^\+[ \t]*\*/) { #no leading * WARN("NETWORKING_BLOCK_COMMENT_STYLE", "networking block comments start with * on subsequent lines\n" . $hereprev); -- 1.8.1.2.459.gbcd45b4.dirty
| |