lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] APEI/ERST: Fix error message formatting
From
Date
On Wed, 2013-07-24 at 22:43 +0530, Naveen N. Rao wrote:
> On 2013/07/22 11:01PM, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > [ 5.525861] ERST: Can not request iomem region <0x c7eff000-0x c7f00000> for ERST.
> >
> > This needs to have leading zeroes. Make it so.

Why does it need leading zeros?

> While looking at this, I noticed that we seem to be using varying field
> widths in our APEI code:
> - einj.c has two instances using %#010llx.
> - apei-base.c uses widths of 10 (4 bytes) and 6 (2 bytes).
>
> Not sure if these are intentional and those fields truly aren't 64-bit
> (as suggested by the usage of long long int).

I suggest using "0x%llx" everywhere unless there's a
compelling reason like columnar alignment for them.




\
 
 \ /
  Last update: 2013-07-24 20:41    [W:0.074 / U:0.116 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site