lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] APEI/ERST: Fix error message formatting
On 2013/07/22 11:01PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> [ 5.525861] ERST: Can not request iomem region <0x c7eff000-0x c7f00000> for ERST.
>
> This needs to have leading zeroes. Make it so.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Anton Vorontsov <anton@enomsg.org>
> Cc: Colin Cross <ccross@android.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Tony Luck <tony.luck@intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
> Cc: linux-acpi@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> drivers/acpi/apei/erst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index 88d0b0f9f92b..1126afeb7e22 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -1168,7 +1168,7 @@ static int __init erst_init(void)
> r = request_mem_region(erst_erange.base, erst_erange.size, "APEI ERST");
> if (!r) {
> pr_err(ERST_PFX
> - "Can not request iomem region <0x%16llx-0x%16llx> for ERST.\n",
> + "Can not request iomem region <0x%016llx-0x%016llx> for ERST.\n",
> (unsigned long long)erst_erange.base,
> (unsigned long long)erst_erange.base + erst_erange.size);
> rc = -EIO;

Acked-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>

While looking at this, I noticed that we seem to be using varying field
widths in our APEI code:
- einj.c has two instances using %#010llx.
- apei-base.c uses widths of 10 (4 bytes) and 6 (2 bytes).

Not sure if these are intentional and those fields truly aren't 64-bit
(as suggested by the usage of long long int).


Regards,
Naveen

> --
> 1.8.3
>



\
 
 \ /
  Last update: 2013-07-24 19:21    [W:0.058 / U:5.032 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site