lkml.org 
[lkml]   [2013]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3.11-rc2] HID: sony: fix HID mapping for PS3 sixaxis controller
Date
Commit f04d51404f51 (HID: driver for PS2/3 Buzz controllers) introduced
an input_mapping() callback, but set the return value to -1 to all devices
except the Buzz controllers. The result of this is that the Sixaxis input
device is not populated, making it useless.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
Hi Jiri,

I have since yesterday a Sixaxis controller on my desk, and I noticed that it
was broken in v3.11.

Cheers,
Benjamin

drivers/hid/hid-sony.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index ecbc749..87fbe29 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -369,7 +369,8 @@ static int sony_mapping(struct hid_device *hdev, struct hid_input *hi,
if (sc->quirks & PS3REMOTE)
return ps3remote_mapping(hdev, hi, field, usage, bit, max);

- return -1;
+ /* Let hid-core decide for the others */
+ return 0;
}

/*
--
1.8.3.1


\
 
 \ /
  Last update: 2013-07-24 17:41    [W:0.030 / U:0.564 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site