lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] lib/vsprintf.c: fix the incorrect return value of vsnprintf()
When "str >= end", necessary to reset 'str' to "end - 1", or the return
value will be larger than the real one, the callers which depend on the
return value, may cause memory overflow.

When for copying constant string, 'str' is point to destination buffer,
so it need add 'copy' (for destination buffer), not 'read' (for source
buffer).

Also add white space between variable and operator to make code cleaner.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
lib/vsprintf.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 739a363..b153768 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1542,7 +1542,7 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
copy = end - str;
memcpy(str, old_fmt, copy);
}
- str += read;
+ str += copy;
break;
}

@@ -1662,12 +1662,14 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
if (size > 0) {
if (str < end)
*str = '\0';
- else
+ else {
end[-1] = '\0';
+ str = end - 1;
+ }
}

/* the trailing null byte doesn't count towards the total */
- return str-buf;
+ return str - buf;

}
EXPORT_SYMBOL(vsnprintf);
--
1.7.7.6

\
 
 \ /
  Last update: 2013-07-18 09:01    [W:0.053 / U:0.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site