lkml.org 
[lkml]   [2013]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] firmware/dmi_scan: Drop OOM messages
From
Date
even more trivial...

On Wed, 2013-07-10 at 14:47 +0200, Jean Delvare wrote:
> +++ linux-3.11-rc0/drivers/firmware/dmi_scan.c 2013-07-10 14:11:56.544792703 +0200
> @@ -62,8 +62,6 @@ static const char * __init dmi_string(co
> str = dmi_alloc(len);
> if (str != NULL)
[]
> @@ -219,10 +217,8 @@ static void __init dmi_save_one_device(i
> dev = dmi_alloc(sizeof(*dev) + strlen(name) + 1);
> + if (!dev)
> return;
[]
> @@ -258,10 +254,8 @@ static void __init dmi_save_oem_strings_
> dev = dmi_alloc(sizeof(*dev));
> + if (!dev)
> break;
[]
> @@ -277,18 +271,14 @@ static void __init dmi_save_ipmi_device(
> data = dmi_alloc(dm->length);
> + if (data == NULL)
> return;
[]
> dev = dmi_alloc(sizeof(*dev));
> + if (!dev)
> return;
[]
> @@ -303,10 +293,9 @@ static void __init dmi_save_dev_onboard(
> onboard_dev = dmi_alloc(sizeof(*onboard_dev) + strlen(name) + 1);
> + if (!onboard_dev)
> return;

It'd also be nice to use the same test style
in all 6 uses.

if (!foo)




\
 
 \ /
  Last update: 2013-07-10 23:59    [W:2.377 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site