Messages in this thread | | | Date | Thu, 06 Jun 2013 11:40:50 +0100 | From | Nick Dyer <> | Subject | Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs |
| |
Mark Brown wrote: > On Wed, Jun 05, 2013 at 02:07:15PM -0700, Dmitry Torokhov wrote: >> On Wed, Jun 05, 2013 at 09:31:39PM +0100, Nick Dyer wrote: > >>> It's partly path dependence - it was implemented like this because regmap >>> wasn't in mainline at the point when I wrote it. Having a dependency on >>> regmap would now be a API break complicating support of customers using >>> older kernels than mainline. I would also have to update a bunch of > >> This was never a good argument for introducing an interface into the >> kernel. > > Indeed, and regmap is very easy to backport - it demands little from the > rest of the kernel and most of that is bus specific so you can pretty > much just copy it into an older kernel.
That is good news. It would still be an extra thing to add to the docs, but not a blocking point.
I am more worried about the address pointer handling and the I2C retries.
| |