lkml.org 
[lkml]   [2013]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs
    On Wed, Jun 05, 2013 at 10:36:45PM +0100, Nick Dyer wrote:
    > Dmitry Torokhov wrote:

    > > What other purposes does it serve? I'd expect you need it during new
    > > board bringup.

    > Run-time examples would be adjusting noise suppression or touch suppression
    > parameters based on something going on in the app layer (eg having
    > different parameters during unlock screen), or tuning report rates based on
    > application requirements, ot to inspect debug data if the touch sensor is
    > faulty. You might say, well we should implement an kernel driver interface
    > for these requirements, but they will vary hugely between different
    > products. We are trying to keep the driver as generic as possible and push

    If this interface varies dramatically between products then that sounds
    like a badly designed interface. Obviously the way the interface is
    being used would be likely to vary between products but what you're
    talking about sounds like parameter get/set stuff which sounds pretty
    generic to me. What userspace chooses to do with the parameters is of
    course another story.

    > product-specific complexity to user space. Hence exposing the register map
    > and implementing user-space libraries to deal with this kind of customisation.

    This sounds like a bad design decision for Linux, it's just asking for
    fragility if userspace can go randomly poking round the entire register
    map of the device with nothing coordinating with the driver code.

    If you expose the paramters to userspace wouldn't that address the
    issue?
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-06-06 13:21    [W:3.528 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site