lkml.org 
[lkml]   [2013]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1 1/8] zram: simplify and optimize zram_to_dev()
On Tue 04 Jun 2013 09:09:05 PM CST, Jerome Marchand wrote:
> Hi,
>
> Please write a commit message, no matter how straightforward a patch may
> seem to you.
> Also the subject suffers from dyslexia: it's dev_to_zram, not zram_to_dev.
>
> Thanks,
> Jerome
Hi Jerome,
Thanks for review, will fix it in next version.
Regards!
Gerry

>
> On 06/03/2013 05:42 PM, Jiang Liu wrote:
>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>> ---
>> drivers/staging/zram/zram_sysfs.c | 13 ++-----------
>> 1 file changed, 2 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/staging/zram/zram_sysfs.c b/drivers/staging/zram/zram_sysfs.c
>> index e6a929d..8cb7822 100644
>> --- a/drivers/staging/zram/zram_sysfs.c
>> +++ b/drivers/staging/zram/zram_sysfs.c
>> @@ -30,18 +30,9 @@ static u64 zram_stat64_read(struct zram *zram, u64 *v)
>> return val;
>> }
>>
>> -static struct zram *dev_to_zram(struct device *dev)
>> +static inline struct zram *dev_to_zram(struct device *dev)
>> {
>> - int i;
>> - struct zram *zram = NULL;
>> -
>> - for (i = 0; i < zram_get_num_devices(); i++) {
>> - zram = &zram_devices[i];
>> - if (disk_to_dev(zram->disk) == dev)
>> - break;
>> - }
>> -
>> - return zram;
>> + return (struct zram *)dev_to_disk(dev)->private_data;
>> }
>>
>> static ssize_t disksize_show(struct device *dev,
>>
>



\
 
 \ /
  Last update: 2013-06-04 17:21    [W:0.162 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site