Messages in this thread Patch in this message | | | From | Jiang Liu <> | Subject | [RFC PATCH v1 3/8] zram: use zram->lock to protect zram_free_page() in swap free notify path | Date | Mon, 3 Jun 2013 23:42:15 +0800 |
| |
zram_free_page() is protected by down_write(&zram->lock) when called by zram_bvec_write(), but there's no such protection when called by zram_slot_free_notify(), which may cause wrong states to zram object.
So enhance zram_slot_free_notify() to acquire writer lock on zram->lock before calling zram_free_page().
Signed-off-by: Jiang Liu <jiang.liu@huawei.com> --- drivers/staging/zram/zram_drv.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c index ee6b67d..0738f6c 100644 --- a/drivers/staging/zram/zram_drv.c +++ b/drivers/staging/zram/zram_drv.c @@ -582,7 +582,9 @@ static void zram_slot_free_notify(struct block_device *bdev, struct zram *zram; zram = bdev->bd_disk->private_data; + down_write(&zram->lock); zram_free_page(zram, index); + up_write(&zram->lock); zram_stat64_inc(zram, &zram->stats.notify_free); } -- 1.8.1.2
| |