Messages in this thread | | | From | Alexandre Belloni <> | Subject | [PATCHv2 0/3] Add support for the Nuvoton NAU7802 ADC to the cfa10049 | Date | Thu, 20 Jun 2013 20:57:52 +0200 |
| |
Hi,
Sorry for the delay, this is v2 of the patchset that adds support for the 3 Nuvoton NAU7802 ADCs present on the CFA-10049 board from Crystalfontz. The first patch adds the driver, the next ones are adding them in the DT after switching the second i2c bus to bitbanging following a lot of timeout issues we have on that bus.
Since v1, I've taken into account the review from Jonathan Cameron, Lars-Peter Clausen and Maxime Ripard: - channels are now statically allocated - no wrappers around i2c functions - sampling_freq is a shared attribute - setting gain is done through scale - cosmetics changes (s/idev/indio_dev/, blank lines before returns) - use of sign_extend32 to extend the sign - reading scale now returns IIO_VAL_FRACTIONAL_LOG2 - no dt lookup for interrupts, this is done in of_i2c.c but that was mask due to a bug.
what I didn't address is setting the external reference voltage through a fixed regulator and I kept the vldo attribute to set the internal voltage reference in the DT as Jonathan seemed to be ok with that. If anybody is using a nau7802 with an external reference, it will still be time to add the fixed regulator. It shouldn't be difficult but I don't have any hardware to test.
Regards,
Alexandre Belloni (1): iio: Add Nuvoton NAU7802 ADC driver
Maxime Ripard (2): ARM: mxs: cfa10049: Switch bus i2c1 to bitbanging ARM: mxs: cfa10049: Add NAU7802 ADCs to the device tree
.../bindings/iio/adc/nuvoton-nau7802.txt | 17 + arch/arm/boot/dts/imx28-cfa10049.dts | 126 +++-- drivers/iio/adc/Kconfig | 9 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/nau7802.c | 603 +++++++++++++++++++++ 5 files changed, 713 insertions(+), 43 deletions(-) create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton-nau7802.txt create mode 100644 drivers/iio/adc/nau7802.c
-- 1.8.1.2
| |