lkml.org 
[lkml]   [2013]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support
From
On Tue, Jun 18, 2013 at 1:33 PM, Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:

> Add support for gpio on Intel BayTrail platforms. BayTrail supports 3 banks
> of gpios called SCORE, NCORE ans SUS with 102, 28 and 44 gpio pins.
> Supports gpio interrupts and ACPI gpio events
>
> Pins may be muxed to alternate function instead of gpio by firmware.
> This driver does not touch the pin muxing and expect firmare
> to set pin muxing and pullup/down properties properly.
>
> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>

I have a feeling this driver will evolve quite a bit and eventually
register a pure pinctrl interface as well (currently it's only using
the ranges as some data container...)

Anyway, it's a good starting point and obviously (I guess?)
gets your hardware up an ticking, so let's take this as a
starting point.

So patch applied.

This thing only seems to use gpiolib-acpi.c for the basic
device matching and IRQ handling backend, is that correct?

What I'm thinking of moving forward is that I have seen
ACPI fragments with things like "PullUp" etc, which is pinctrl
domain, so we may come to need some generic ACPI helpers
inside drivers/pinctrl as well sooner or later.

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2013-06-19 01:01    [W:0.119 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site