lkml.org 
[lkml]   [2013]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] tpm: tpm_i2c_infinion: Don't modify i2c_client->driver
Date
The I2C client driver is not supposed to modify the client's driver pointer,
this is handled by the I2C core.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/char/tpm/tpm_i2c_infineon.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c
index 37d5dcc..dbc7042 100644
--- a/drivers/char/tpm/tpm_i2c_infineon.c
+++ b/drivers/char/tpm/tpm_i2c_infineon.c
@@ -74,7 +74,6 @@ struct tpm_inf_dev {
};

static struct tpm_inf_dev tpm_dev;
-static struct i2c_driver tpm_tis_i2c_driver;

/*
* iic_tpm_read() - read from TPM register
@@ -744,11 +743,9 @@ static int tpm_tis_i2c_probe(struct i2c_client *client,
return -ENODEV;
}

- client->driver = &tpm_tis_i2c_driver;
tpm_dev.client = client;
rc = tpm_tis_i2c_init(&client->dev);
if (rc != 0) {
- client->driver = NULL;
tpm_dev.client = NULL;
rc = -ENODEV;
}
--
1.8.0


\
 
 \ /
  Last update: 2013-06-15 16:41    [W:0.065 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site