Messages in this thread Patch in this message | | | From | Cong Wang <> | Subject | [Patch] quota: do not leak info to user-space | Date | Fri, 10 May 2013 17:24:33 +0800 |
| |
From: Cong Wang <amwang@redhat.com>
There is a hole in struct fs_quota_stat, so we have to zero the struct on stack before copying it to user-space.
Cc: Jan Kara <jack@suse.cz> Signed-off-by: Cong Wang <amwang@redhat.com>
--- diff --git a/fs/quota/quota.c b/fs/quota/quota.c index c7314f1..2b0c182 100644 --- a/fs/quota/quota.c +++ b/fs/quota/quota.c @@ -211,6 +211,7 @@ static int quota_getxstate(struct super_block *sb, void __user *addr) if (!sb->s_qcop->get_xstate) return -ENOSYS; + memset(&fqs, 0, sizeof(fqs)); ret = sb->s_qcop->get_xstate(sb, &fqs); if (!ret && copy_to_user(addr, &fqs, sizeof(fqs))) return -EFAULT;
| |