lkml.org 
[lkml]   [2013]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[Patch] quota: do not leak info to user-space
Date
From: Cong Wang <amwang@redhat.com>

There is a hole in struct fs_quota_stat, so we have to
zero the struct on stack before copying it to user-space.

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Cong Wang <amwang@redhat.com>

---
diff --git a/fs/quota/quota.c b/fs/quota/quota.c
index c7314f1..2b0c182 100644
--- a/fs/quota/quota.c
+++ b/fs/quota/quota.c
@@ -211,6 +211,7 @@ static int quota_getxstate(struct super_block *sb, void __user *addr)

if (!sb->s_qcop->get_xstate)
return -ENOSYS;
+ memset(&fqs, 0, sizeof(fqs));
ret = sb->s_qcop->get_xstate(sb, &fqs);
if (!ret && copy_to_user(addr, &fqs, sizeof(fqs)))
return -EFAULT;

\
 
 \ /
  Last update: 2013-05-10 12:01    [W:0.170 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site