lkml.org 
[lkml]   [2013]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] To add NULL pointer check
From
2013/4/3, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
> Hi,
> Thank you for your contribution.
>
> As I consider the null pointer check, generic_writepages() originally
> does so.
> Therefore, I think f2fs_write_data_pages() is better to handle this.
> Please review the modified patch.
> Thanks,
>
> ---
> From d3c811a51c7062fb1b66bec910ed346447c02032 Mon Sep 17 00:00:00 2001
> From: P J P <ppandit@redhat.com>
> Date: Wed, 3 Apr 2013 11:38:00 +0900
> Subject: [PATCH] f2fs: add NULL pointer check
> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
> linux-f2fs-devel@lists.sourceforge.net
>
> Commit - fa9150a84c - replaces a call to generic_writepages() in
> f2fs_write_data_pages() with write_cache_pages(), with a function
> pointer
> argument pointing to routine: __f2fs_writepage.
>
> ->
> https://git.kernel.org/linus/fa9150a84ca333f68127097c4fa1eda4b3913a22
>
> This patch adds a NULL pointer check in f2fs_write_data_pages() to
> avoid
> a possible NULL pointer dereference, in case if -
> mapping->a_ops->writepage -
> is NULL.
Yes, I agree. Looks better!
Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>

Thanks.
>
> Signed-off-by: P J P <ppandit@redhat.com>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> ---


\
 
 \ /
  Last update: 2013-04-03 07:01    [W:0.051 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site