Messages in this thread | | | Date | Wed, 3 Apr 2013 12:30:00 +0530 (IST) | From | P J P <> | Subject | Re: [PATCH] To add NULL pointer check |
| |
+-- On Wed, 3 Apr 2013, Jaegeuk Kim wrote --+ | diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c | index 47a2d7c..cf9ff5f 100644 | --- a/fs/f2fs/data.c | +++ b/fs/f2fs/data.c | @@ -559,6 +559,10 @@ static int f2fs_write_data_pages(struct | address_space *mapping, | int ret; | long excess_nrtw = 0, desired_nrtw; | | + /* deal with chardevs and other special file */ | + if (!mapping->a_ops->writepage) | + return 0; | +
Small question, is it okay to `return 0' here?
Earlier even if `generic_writepages' returned 0, that did not abort routine `f2fs_write_data_pages'.
Thank you. -- Prasad J Pandit / Red Hat Security Response Team DB7A 84C5 D3F9 7CD1 B5EB C939 D048 7860 3655 602B
| |