Messages in this thread | | | Date | Fri, 29 Mar 2013 14:57:30 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 2/2] hugetlbfs: add swap entry check in follow_hugetlb_page() |
| |
On Thu 28-03-13 11:42:38, Naoya Horiguchi wrote: [...] > @@ -2968,7 +2968,8 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma, > * first, for the page indexing below to work. > */ > pte = huge_pte_offset(mm, vaddr & huge_page_mask(h)); > - absent = !pte || huge_pte_none(huge_ptep_get(pte)); > + absent = !pte || huge_pte_none(huge_ptep_get(pte)) || > + is_swap_pte(huge_ptep_get(pte));
is_swap_pte doesn't seem right. Shouldn't you use is_hugetlb_entry_hwpoisoned instead?
-- Michal Hocko SUSE Labs
| |