Messages in this thread | | | Date | Thu, 28 Mar 2013 21:03:16 +0400 | From | Konstantin Khlebnikov <> | Subject | Re: [PATCH 1/2] hugetlbfs: stop setting VM_DONTDUMP in initializing vma(VM_HUGETLB) |
| |
Naoya Horiguchi wrote: > Currently we fail to include any data on hugepages into coredump, > because VM_DONTDUMP is set on hugetlbfs's vma. This behavior was recently > introduced by commit 314e51b98 "mm: kill vma flag VM_RESERVED and > mm->reserved_vm counter". This looks to me a serious regression, > so let's fix it.
That was introduced in my patch? Really? Here was VM_RESERVED and it had the same effect as VM_DONTDUMP. At least I thought so.
> > Signed-off-by: Naoya Horiguchi<n-horiguchi@ah.jp.nec.com> > Cc: Konstantin Khlebnikov<khlebnikov@openvz.org> > --- > fs/hugetlbfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git v3.9-rc3.orig/fs/hugetlbfs/inode.c v3.9-rc3/fs/hugetlbfs/inode.c > index 84e3d85..523464e 100644 > --- v3.9-rc3.orig/fs/hugetlbfs/inode.c > +++ v3.9-rc3/fs/hugetlbfs/inode.c > @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) > * way when do_mmap_pgoff unwinds (may be important on powerpc > * and ia64). > */ > - vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND | VM_DONTDUMP; > + vma->vm_flags |= VM_HUGETLB | VM_DONTEXPAND; > vma->vm_ops =&hugetlb_vm_ops; > > if (vma->vm_pgoff& (~huge_page_mask(h)>> PAGE_SHIFT))
| |