Messages in this thread | | | Date | Thu, 28 Mar 2013 18:01:42 +0000 | From | Thomas Graf <> | Subject | Re: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_* |
| |
On 03/29/13 at 12:08am, Hong zhi guo wrote: > Thanks, Thomas. But I didn't change any formatting. Just do the > substitution in place.
Your change would require reformatting on the lines following your change because the required level of indentation changed. I don't want to cause you unneeded pain but it really helps everyone used to the kernel coding style.
> >> - rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) + > >> - sizeof(struct inet_diag_meminfo) + > >> - 64)), GFP_KERNEL); > >> + rep = nlmsg_new(sizeof(struct inet_diag_msg) + > >> + sizeof(struct inet_diag_meminfo) + 64, > >> + GFP_KERNEL); ^^^^^^^^^^^^^^
> Should I re-format and re-send the patch?
Yes please, just resubmit the patches that changed and include a proper vN in the subject.
| |