lkml.org 
[lkml]   [2013]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_*
On 03/29/13 at 12:08am, Hong zhi guo wrote:
> Thanks, Thomas. But I didn't change any formatting. Just do the
> substitution in place.

Your change would require reformatting on the lines following
your change because the required level of indentation changed.
I don't want to cause you unneeded pain but it really helps
everyone used to the kernel coding style.

> >> - rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) +
> >> - sizeof(struct inet_diag_meminfo) +
> >> - 64)), GFP_KERNEL);
> >> + rep = nlmsg_new(sizeof(struct inet_diag_msg) +
> >> + sizeof(struct inet_diag_meminfo) + 64,
> >> + GFP_KERNEL);
^^^^^^^^^^^^^^

> Should I re-format and re-send the patch?

Yes please, just resubmit the patches that changed and include
a proper vN in the subject.


\
 
 \ /
  Last update: 2013-03-28 19:41    [W:0.100 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site