Messages in this thread Patch in this message | | | Date | Thu, 28 Mar 2013 14:00:57 -0400 (EDT) | Subject | Re: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg_* | From | David Miller <> |
| |
From: Thomas Graf <tgraf@suug.ch> Date: Thu, 28 Mar 2013 14:32:16 +0000
> On 03/28/13 at 12:47am, Hong Zhiguo wrote: >> diff --git a/net/ipv4/udp_diag.c b/net/ipv4/udp_diag.c >> index 505b30a..467fb92 100644 >> --- a/net/ipv4/udp_diag.c >> +++ b/net/ipv4/udp_diag.c >> @@ -64,9 +64,9 @@ static int udp_dump_one(struct udp_table *tbl, struct sk_buff *in_skb, >> goto out; >> >> err = -ENOMEM; >> - rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) + >> - sizeof(struct inet_diag_meminfo) + >> - 64)), GFP_KERNEL); >> + rep = nlmsg_new(sizeof(struct inet_diag_msg) + >> + sizeof(struct inet_diag_meminfo) + 64, >> + GFP_KERNEL); > > This is formatted incorrectly, otherwise the patch looks good.
I'll fix it up when I commit.
| |