Messages in this thread Patch in this message | | | From | "ethan.zhao" <> | Subject | [PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR | Date | Sun, 8 Dec 2013 10:41:46 +0800 |
| |
function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR().
Signed-off-by: ethan.zhao <ethan.kernel@gmail.com> --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c index a0f6a17..93190ab 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c @@ -151,7 +151,7 @@ static int rcar_du_lvdsenc_get_resources(struct rcar_du_lvdsenc *lvds, } lvds->mmio = devm_ioremap_resource(&pdev->dev, mem); - if (lvds->mmio == NULL) { + if (IS_ERR(lvds->mmio)) { dev_err(&pdev->dev, "failed to remap memory resource for %s\n", name); return -ENOMEM; -- 1.8.3.4 (Apple Git-47)
| |