lkml.org 
[lkml]   [2013]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/3] regulator: act8865: add PMIC act8865 driver
On Tue, Dec 24, 2013 at 10:34:28AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

I've applied this, however there is one small issue which I seem to have
forgotten to point out previously:

> + /* Finally register devices */
> + for (i = 0; i < pdata->num_regulators; i++) {

The driver should register all regulators regardless of how many are
used in the system in order to aid diagnostics. Please send an
incremental patch to fix this.


\
 
 \ /
  Last update: 2013-12-24 15:21    [W:0.078 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site