| Subject | Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver | From | Andy Shevchenko <> | Date | Thu, 27 Sep 2012 12:43:42 +0300 |
| |
On Thu, 2012-09-27 at 14:14 +0530, Vinod Koul wrote: > > +static int __devinit dw_pci_probe(struct pci_dev *pdev, > > + const struct pci_device_id *id) > > +{ > ... > > + > > + pd = platform_device_alloc("dw_dmac", instance); > Why can't the core driver library be agnostic. Why do we care if the > device is platform, pci or something else. > There is nothing in dma API callbacks which driver implements that > warrants it to be some device. > > You have already taken care of dma controller accesses be arch > independent so I don't see a reason why this should be done? I'm afraid I didn't get you comment.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
|