lkml.org 
[lkml]   [2012]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver
From
Date
On Thu, 2012-09-27 at 14:14 +0530, Vinod Koul wrote: 
> > +static int __devinit dw_pci_probe(struct pci_dev *pdev,
> > + const struct pci_device_id *id)
> > +{
> ...
> > +
> > + pd = platform_device_alloc("dw_dmac", instance);
> Why can't the core driver library be agnostic. Why do we care if the
> device is platform, pci or something else.
> There is nothing in dma API callbacks which driver implements that
> warrants it to be some device.
>
> You have already taken care of dma controller accesses be arch
> independent so I don't see a reason why this should be done?
I'm afraid I didn't get you comment.


--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy


\
 
 \ /
  Last update: 2012-09-27 12:21    [W:2.822 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site