lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv3 1/7] dmaengine: dw_dmac: use helper macro module_platform_driver()
From
Date
On Thu, 2012-09-27 at 10:40 +0300, Felipe Balbi wrote: 
> On Thu, Sep 27, 2012 at 10:31:55AM +0300, Andy Shevchenko wrote:
> > From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> >
>
> commit log would be great.
Will do.

> > static struct platform_driver dw_driver = {
> > + .probe = dw_probe,
>
> probe's in __init section. This is wrong. You need to change probe
> __devinit.
Have you checked this one
0272e93f364eac1a30f2831adcaca3dd633d5f14

Or might be I missed something?


--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy


\
 
 \ /
  Last update: 2012-10-01 13:21    [W:0.212 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site