Messages in this thread | | | Date | Fri, 21 Sep 2012 19:30:48 +0530 | Subject | Re: [PATCHv2 4/6] dw_dmac: autoconfigure block_size or use platform data | From | viresh kumar <> |
| |
On Fri, Sep 21, 2012 at 5:35 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > @@ -1385,6 +1375,7 @@ static int __devinit dw_probe(struct platform_device *pdev)
> + /* get hardware configuration parameters */ > + if (autocfg) > + max_blk_size = dma_readl(dw, MAX_BLK_SIZE); > +
Why don't you do above with the below ++ code
> /* Calculate all channel mask before DMA setup */ > dw->all_chan_mask = (1 << nr_channels) - 1; > > @@ -1470,6 +1465,16 @@ static int __devinit dw_probe(struct platform_device *pdev) > INIT_LIST_HEAD(&dwc->free_list); > > channel_clear_bit(dw, CH_EN, dwc->mask); > + > + /* hardware configuration */ > + if (autocfg) > + /* Decode maximum block size for given channel. The > + * stored 4 bit value represents blocks from 0x00 for 3 > + * up to 0x0a for 4095. */
i.e. here?
> + dwc->block_size = > + (4 << ((max_blk_size >> 4 * i) & 0xf)) - 1; > + else > + dwc->block_size = pdata->block_size; > }
| |