Messages in this thread Patch in this message | | | Date | Wed, 19 Sep 2012 10:04:07 -0700 | From | tip-bot for Dan Carpenter <> | Subject | [tip:perf/core] perf: Fix off by one test in perf_reg_value() |
| |
Commit-ID: 1e6dd8adc78d4a153db253d051fd4ef6c49c9019 Gitweb: http://git.kernel.org/tip/1e6dd8adc78d4a153db253d051fd4ef6c49c9019 Author: Dan Carpenter <dan.carpenter@oracle.com> AuthorDate: Wed, 5 Sep 2012 15:31:26 +0300 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 19 Sep 2012 17:08:40 +0200
perf: Fix off by one test in perf_reg_value()
The test should be >= ARRAY_SIZE() instead of > ARRAY_SIZE().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Link: http://lkml.kernel.org/r/20120905123126.GC6128@elgon.mountain Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/kernel/perf_regs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/perf_regs.c b/arch/x86/kernel/perf_regs.c index c5a3e5c..e309cc5 100644 --- a/arch/x86/kernel/perf_regs.c +++ b/arch/x86/kernel/perf_regs.c @@ -57,7 +57,7 @@ static unsigned int pt_regs_offset[PERF_REG_X86_MAX] = { u64 perf_reg_value(struct pt_regs *regs, int idx) { - if (WARN_ON_ONCE(idx > ARRAY_SIZE(pt_regs_offset))) + if (WARN_ON_ONCE(idx >= ARRAY_SIZE(pt_regs_offset))) return 0; return regs_get_register(regs, pt_regs_offset[idx]);
| |