lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [dm-devel] [PATCH v5 12/12] block: Only clone bio vecs that are in use
On Mon, Aug 06, 2012 at 07:16:33PM -0400, Mikulas Patocka wrote:
> Hi Kent
>
> When you change the semantics of an exported function, rename that
> function. There may be external modules that use __bio_clone and this
> change could silently introduce bugs in them.
>
> Otherwise, the patchset looks fine.

I don't know. This doesn't change the main functionality and should
be transparent unless the caller is doing something crazy. It *might*
be nice to rename but I don't think that's a must here.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-08-09 01:41    [W:0.273 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site