Messages in this thread | | | Date | Wed, 8 Aug 2012 16:28:04 -0700 | From | Tejun Heo <> | Subject | Re: [dm-devel] [PATCH v5 12/12] block: Only clone bio vecs that are in use |
| |
On Mon, Aug 06, 2012 at 07:16:33PM -0400, Mikulas Patocka wrote: > Hi Kent > > When you change the semantics of an exported function, rename that > function. There may be external modules that use __bio_clone and this > change could silently introduce bugs in them. > > Otherwise, the patchset looks fine.
I don't know. This doesn't change the main functionality and should be transparent unless the caller is doing something crazy. It *might* be nice to rename but I don't think that's a must here.
Thanks.
-- tejun
| |