lkml.org 
[lkml]   [2012]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [dm-devel] [PATCH v5 12/12] block: Only clone bio vecs that are in use
    From
    Tejun,

    This is changing the semantics of the clone. Sorry, I missed this
    thread and replied separately. But anyway, replying it again here:


    On Wed, Aug 8, 2012 at 4:28 PM, Tejun Heo <tj@kernel.org> wrote:
    > On Mon, Aug 06, 2012 at 07:16:33PM -0400, Mikulas Patocka wrote:
    >> Hi Kent
    >>
    >> When you change the semantics of an exported function, rename that
    >> function. There may be external modules that use __bio_clone and this
    >> change could silently introduce bugs in them.
    >>
    >> Otherwise, the patchset looks fine.
    >
    > I don't know. This doesn't change the main functionality and should
    > be transparent unless the caller is doing something crazy. It *might*
    > be nice to rename but I don't think that's a must here.
    >
    > Thanks.

    --
    You are changing the meaning of __bio_clone() here. In old code, the
    number of io_vecs, bi_idx, bi_vcnt are preserved. But in this modified
    code, you are mapping bio_src's bi_iovec[bi_idx] to bio_dests
    bi_iovec[0] and also restricting the number of allocated io_vecs of
    the clone. It may be useful for cases were we would like a identical
    copy of the original bio (may not be in current code base, but this
    implementation is definitely not what one would expect from the name
    "clone").

    May be, call this new implementation some thing else (and use it for bcache)?

    ---

    Like Mikulas pointed out, this is an exported function and silently
    changing the semantics will break external modules.

    Regards,
    Muthu


    >
    > --
    > tejun
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/


    \
     
     \ /
      Last update: 2012-08-09 02:41    [W:0.062 / U:4.048 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site