lkml.org 
[lkml]   [2012]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 8/9] rbtree: faster augmented rbtree manipulation
From
Date
On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:
> +void __rb_insert_augmented(struct rb_node *node, struct rb_root *root,
> + void (*augment_rotate)(struct rb_node *old, struct rb_node *new))
> +{
> + __rb_insert(node, root, augment_rotate);
> +}
> +EXPORT_SYMBOL(__rb_insert_augmented);
> +
> +void rb_erase_augmented(struct rb_node *node, struct rb_root *root,
> + const struct rb_augment_callbacks *augment)
> +{
> + __rb_erase(node, root, augment);
> +}
> +EXPORT_SYMBOL(rb_erase_augmented);

From a symmetry POV I'd say have both take the rb_augment_callbacks
thing. The two taking different arguments is confusing at best.


\
 
 \ /
  Last update: 2012-08-06 17:41    [W:0.208 / U:1.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site