| Subject | Re: [PATCH v2 3/9] rbtree: add __rb_change_child() helper function | From | Peter Zijlstra <> | Date | Mon, 06 Aug 2012 16:22:10 +0200 |
| |
On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote: > +static inline void
I would make that __always_inline, just to make sure GCC doesn't go creative on us.
> +__rb_change_child(struct rb_node *old, struct rb_node *new, > + struct rb_node *parent, struct rb_root *root) > +{ > + if (parent) { > + if (parent->rb_left == old) > + parent->rb_left = new; > + else > + parent->rb_right = new; > + } else > + root->rb_node = new; > +}
|