lkml.org 
[lkml]   [2012]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 8/14] drivers/video/sunxvr2500.c: fix error return code
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    Initialize return variable before exiting on an error path.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    // <smpl>
    (
    if@p1 (\(ret < 0\|ret != 0\))
    { ... return ret; }
    |
    ret@p1 = 0
    )
    ... when != ret = e1
    when != &ret
    *if(...)
    {
    ... when != ret = e2
    when forall
    return ret;
    }

    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/video/sunxvr2500.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/video/sunxvr2500.c b/drivers/video/sunxvr2500.c
    index 5848436..7fbcba8 100644
    --- a/drivers/video/sunxvr2500.c
    +++ b/drivers/video/sunxvr2500.c
    @@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev,
    sp->fb_size = info->fix.line_length * sp->height;

    sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size);
    - if (!sp->fb_base)
    + if (!sp->fb_base) {
    + err = -ENOMEM;
    goto err_release_pci;
    + }

    err = s3d_set_fbinfo(sp);
    if (err)


    \
     
     \ /
      Last update: 2012-08-19 11:41    [W:0.021 / U:185.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site