Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 9/14] drivers/spi/spi-omap-100k.c: fix error return code | Date | Sun, 19 Aug 2012 10:44:28 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; }
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- Actually, omap1_spi100k_reset currently always returns 0, so the test is never true. Perhaps this should be taken into account in some other way.
drivers/spi/spi-omap-100k.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-omap-100k.c b/drivers/spi/spi-omap-100k.c index 9bd1c92..b581107 100644 --- a/drivers/spi/spi-omap-100k.c +++ b/drivers/spi/spi-omap-100k.c @@ -542,7 +542,8 @@ static int __devinit omap1_spi100k_probe(struct platform_device *pdev) goto err2; } - if (omap1_spi100k_reset(spi100k) < 0) + status = omap1_spi100k_reset(spi100k); + if (status < 0) goto err3; status = spi_register_master(master);
| |