lkml.org 
[lkml]   [2012]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] drivers/mfd: Add realtek pcie card reader driver
On Wed, Aug 15, 2012 at 06:40:54AM +0000, Arnd Bergmann wrote:
> On Tuesday 14 August 2012, wei_wang@realsil.com.cn wrote:
> > +
> > +void rtsx_pci_start_run(struct rtsx_pcr *pcr)
> > +{
> > + /* If pci device removed, don't queue idle work any more */
> > + if (pcr->remove_pci)
> > + return;
> > +
> > + if (pcr->state != PDEV_STAT_RUN) {
> > + pcr->state = PDEV_STAT_RUN;
> > + pcr->ops->enable_auto_blink(pcr);
> > + }
> > +
> > + mod_timer(&pcr->idle_timer, jiffies + msecs_to_jiffies(200));
> > +}
> > +EXPORT_SYMBOL_GPL(rtsx_pci_start_run);
>
> One more comment on the mod_timer/queue_work combination: I just saw that
> Tejun Heo posted a series to introduce a new mod_delayed_work() helper.
>
> Once that goes in, it would be best to start using it here.

mod_delayed_work() is now in the following git branch.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git wq-mod_delayed

The branch is stable and will be pushed during for-3.7 merge window.
Please feel free to pull as necessary.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2012-08-17 00:21    [W:0.071 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site