lkml.org 
[lkml]   [2012]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subject[RFC] SCSI: drivers: Remove unnecessary assignment of scsi_done in driver queuecommand
From
[ CCing signed-off, acked-by of original patch - let me know if anyone
else needs to be added ]

Jeff, James,

In the following commit:
----------
commit f281233d3eba15fb225d21ae2e228fd4553d824a
Author: Jeff Garzik <jeff@garzik.org>
Date: Tue Nov 16 02:10:29 2010 -0500

SCSI host lock push-down
---------

queuecommand syntax is changed to no longer passing done() routine as
parameter. Instead, in scsi_dispatch_command and scsi_send_eh_cmnd,
scsi_cmd->scsi_done is set to done() before calling the driver
specific queuecommand.
But all the drivers queuecommand routines still do the redundant assignment:

scsi_cmd->scsi_done = done

For example:

cciss_scsi_queue_command_lck():
..
cmd->scsi_done = done; // save this for use by completion code
..

How about removing all such redundant assignments?

Regards,
Muthu


\
 
 \ /
  Last update: 2012-07-09 02:21    [W:0.223 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site