Messages in this thread | | | Date | Sun, 8 Jul 2012 16:35:03 -0700 | Subject | [RFC] SCSI: drivers: Remove unnecessary assignment of scsi_done in driver queuecommand | From | Muthu Kumar <> |
| |
[ CCing signed-off, acked-by of original patch - let me know if anyone else needs to be added ]
Jeff, James,
In the following commit: ---------- commit f281233d3eba15fb225d21ae2e228fd4553d824a Author: Jeff Garzik <jeff@garzik.org> Date: Tue Nov 16 02:10:29 2010 -0500
SCSI host lock push-down ---------
queuecommand syntax is changed to no longer passing done() routine as parameter. Instead, in scsi_dispatch_command and scsi_send_eh_cmnd, scsi_cmd->scsi_done is set to done() before calling the driver specific queuecommand. But all the drivers queuecommand routines still do the redundant assignment:
scsi_cmd->scsi_done = done
For example:
cciss_scsi_queue_command_lck(): .. cmd->scsi_done = done; // save this for use by completion code ..
How about removing all such redundant assignments?
Regards, Muthu
| |