lkml.org 
[lkml]   [2012]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] drivers/iommu/tegra-smmu.c: remove invalid reference to list iterator variable
Hi Julia,

On Mon, 23 Jul 2012 19:59:21 +0200
Stephen Warren <swarren@wwwdotorg.org> wrote:

> On 07/08/2012 05:37 AM, Julia Lawall wrote:
> > From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Julia,
>
> It looks like this patch hasn't seen any replies since you didn't CC the
> maintainers of this code. I've CC'd them now.
>
> > If list_for_each_entry, etc complete a traversal of the list, the iterator
> > variable ends up pointing to an address at an offset from the list head,
> > and not a meaningful structure. Thus this value should not be used after
> > the end of the iterator. Replace c->dev by dev, which is the value that
> > c->dev has been compared to.
> >
> > This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Acked-by: Stephen Warren <swarren@wwwdotorg.org>

Acked-by: Hiroshi DOYU <hdoyu@nvidia.com>
Ok to me too. Thanks.


\
 
 \ /
  Last update: 2012-07-24 11:21    [W:0.356 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site