lkml.org 
[lkml]   [2012]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] drivers/s390/scsi/zfcp_cfdc.c: remove invalid reference to list iterator variable
    Date
    From: Julia Lawall <Julia.Lawall@lip6.fr>

    If list_for_each_entry, etc complete a traversal of the list, the iterator
    variable ends up pointing to an address at an offset from the list head,
    and not a meaningful structure. Thus this value should not be used after
    the end of the iterator. Replace port->adapter->scsi_host by
    adapter->scsi_host.

    This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    This is not tested, an I am not sure that this is the right change.
    Indeed, I'm not at all sure how the original code could have worked, since
    port->adapter->scsi_host should be a completely random value.

    drivers/s390/scsi/zfcp_cfdc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/s390/scsi/zfcp_cfdc.c b/drivers/s390/scsi/zfcp_cfdc.c
    index fab2c25..8ed63aa 100644
    --- a/drivers/s390/scsi/zfcp_cfdc.c
    +++ b/drivers/s390/scsi/zfcp_cfdc.c
    @@ -293,7 +293,7 @@ void zfcp_cfdc_adapter_access_changed(struct zfcp_adapter *adapter)
    }
    read_unlock_irqrestore(&adapter->port_list_lock, flags);

    - shost_for_each_device(sdev, port->adapter->scsi_host) {
    + shost_for_each_device(sdev, adapter->scsi_host) {
    zfcp_sdev = sdev_to_zfcp(sdev);
    status = atomic_read(&zfcp_sdev->status);
    if ((status & ZFCP_STATUS_COMMON_ACCESS_DENIED) ||


    \
     
     \ /
      Last update: 2012-07-08 14:01    [W:0.021 / U:3.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site