lkml.org 
[lkml]   [2012]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] drm, ast_fb: Fix a small leak in astfb_create()
We have this code:

...
sysram = vmalloc(size);
if (!sysram)
return -ENOMEM;

info = framebuffer_alloc(0, device);
if (!info) {
ret = -ENOMEM;
goto out;
}
...

We'll leak the memory allocated to 'sysram' if the framebuffer_alloc()
call fails and the variable goes out of scope.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/gpu/drm/ast/ast_fb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 2fc8e9e..260a760 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -180,6 +180,7 @@ static int astfb_create(struct ast_fbdev *afbdev,

info = framebuffer_alloc(0, device);
if (!info) {
+ vfree(sysram);
ret = -ENOMEM;
goto out;
}
--
1.7.11.2

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2012-07-20 21:41    [W:0.033 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site