lkml.org 
[lkml]   [2012]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: wlan-ng: Fix problem with wrong arguments
    Date
    The function pointer scan in struct cfg80211_ops is not
    supposed to be assigned a function with a struct net_device
    pointer as an argument. Instead access the net_device struct
    in the following way:

    struct net_device *dev = request->wdev->netdev;

    sparse gives these warnings:

    drivers/staging/wlan-ng/cfg80211.c:726:17: warning:
    incorrect type in initializer (incompatible argument 2
    (different base types))
    expected int ( *scan )( ... )
    got int ( extern [toplevel] *<noident> )( ... )

    drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
    initialization from incompatible pointer type [enabled by default]

    drivers/staging/wlan-ng/cfg80211.c:726:2: warning:
    (near initialization for ‘prism2_usb_cfg_ops.scan’)
    [enabled by default]

    Signed-off-by: Emil Goode <emilgoode@gmail.com>
    ---
    drivers/staging/wlan-ng/cfg80211.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
    index fabff4d..0970127 100644
    --- a/drivers/staging/wlan-ng/cfg80211.c
    +++ b/drivers/staging/wlan-ng/cfg80211.c
    @@ -327,9 +327,9 @@ int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
    return result;
    }

    -int prism2_scan(struct wiphy *wiphy, struct net_device *dev,
    - struct cfg80211_scan_request *request)
    +int prism2_scan(struct wiphy *wiphy, struct cfg80211_scan_request *request)
    {
    + struct net_device *dev = request->wdev->netdev;
    struct prism2_wiphy_private *priv = wiphy_priv(wiphy);
    wlandevice_t *wlandev = dev->ml_priv;
    struct p80211msg_dot11req_scan msg1;
    --
    1.7.10.4
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-07-14 02:01    [W:0.069 / U:0.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site