Messages in this thread | | | Date | Thu, 21 Jun 2012 01:32:31 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] x86, microcode: Make reload interface per system |
| |
On Wed, Jun 20, 2012 at 04:27:58PM -0700, H. Peter Anvin wrote: > On 06/20/2012 04:23 PM, Borislav Petkov wrote: > > On Wed, Jun 20, 2012 at 04:10:18PM -0700, H. Peter Anvin wrote: > >> I'm wondering about the new format... it seems to potentially make it > >> harder to do the proper retaining of compatible CPU microcodes. > > > > .. and if you don't split the blob, you have all the ucode patches in > > one package. So are there any advantages in splitting the single blob? > > > > Not that I know of. IMO the driver can, and should, be the one doing > the pruning.
Which means that
static enum ucode_state request_microcode_fw(int cpu, struct device *device) { char name[30];
...
sprintf(name, "intel-ucode/%02x-%02x-%02x", c->x86, c->x86_model, c->x86_mask);
needs to be changed to the name of the microcode blob you guys use for distributing and we can drop the OLD INTERFACE and there'll be no need for userspace tools doing anything with the ucode patches.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |